Skip to content

Conversation

FBIKdot
Copy link
Contributor

@FBIKdot FBIKdot commented Jun 19, 2025

The site content is the docs of hnxml. The site was deployed by workflow https://github.com/Modern-School/hnxml/blob/master/.github/workflows/deploy-docs.yml so it's source doesn't appear in the repository.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Jun 19, 2025
@indus
Copy link
Member

indus commented Jun 19, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

I'll merge after we have "contact". Please keep this PR open.

@FBIKdot
Copy link
Contributor Author

FBIKdot commented Jun 20, 2025

@indus It works!

@indus
Copy link
Member

indus commented Jun 20, 2025

Welcome https://hnxml.js.org

@indus indus merged commit 55acc0d into js-org:master Jun 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants