Skip to content

Conversation

weareoutman
Copy link
Contributor

@weareoutman weareoutman commented Jan 21, 2025

The site content is ...

@MattIPv4 MattIPv4 changed the title Add plain-blog plain-blog.js.org Jan 21, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/weareoutman/plain-blog/tree/gh-pages

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jan 21, 2025
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jan 21, 2025
@indus
Copy link
Member

indus commented Jan 21, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because it looks like you are using a workflow to deploy the page (and not the gh-pages branch), additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@weareoutman
Copy link
Contributor Author

No, I'm using the default "Deploy from a branch" with "gh-pages", don't know what I have to do.

I'm using a workflow to push new commit to the gh-pages.

image

@MattIPv4
Copy link
Member

Seems to be working fine for me:

curl -is https://plain-blog.js.org | grep \<title\>
<!DOCTYPE html><html><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1"/><title>Plain Blog</title>...

@weareoutman
Copy link
Contributor Author

Working fine to me as well, thanks 🎉

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jan 21, 2025
@indus
Copy link
Member

indus commented Jan 21, 2025

May have tested to fast after adding...
Welcome https://plain-blog.js.org

@indus indus merged commit ab9cb88 into js-org:master Jan 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants