Skip to content

Conversation

nascjoao
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/nascjoao/tikjs/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Aug 19, 2024
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Aug 19, 2024
@indus
Copy link
Member

indus commented Aug 19, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line tik.js.org to make it work. In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)
I'll merge after we have "contact". Please keep this PR open.

@nascjoao
Copy link
Contributor Author

nascjoao commented Aug 19, 2024

It seems to have worked, @indus. Thank you!

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Aug 20, 2024
@indus
Copy link
Member

indus commented Aug 20, 2024

Welcome https://tik.js.org

@indus indus merged commit f16ee03 into js-org:master Aug 20, 2024
@nascjoao nascjoao deleted the patch-1 branch August 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants