Skip to content

snail-ide.js.org #8632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2023
Merged

snail-ide.js.org #8632

merged 4 commits into from
Nov 13, 2023

Conversation

nmsderp
Copy link
Contributor

@nmsderp nmsderp commented Nov 11, 2023

@nmsderp nmsderp changed the title snail ide snail-ide.js.org Nov 11, 2023
MattIPv4
MattIPv4 requested changes Nov 11, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain invalid labels Nov 11, 2023
@MattIPv4
Copy link
Member

Your entry in cnames_active.js also needs to be in alphabetical order, please :)

@nmsderp nmsderp requested a review from MattIPv4 November 11, 2023 21:37
@nmsderp
Copy link
Contributor Author

nmsderp commented Nov 11, 2023

Should be fixed

@indus
Copy link
Member

indus commented Nov 12, 2023

I've just added your requested subdomain provisionally to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

You also have to remove the trailing / before this can be merged: https://github.com/js-org/js.org/actions/runs/6836685345/job/18595689751?pr=8632

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation labels Nov 12, 2023
@nmsderp
Copy link
Contributor Author

nmsderp commented Nov 12, 2023

It might work now

@indus indus merged commit 7fab753 into js-org:master Nov 13, 2023
@indus
Copy link
Member

indus commented Nov 13, 2023

Welcome https://snail-ide.js.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattIPv4 MattIPv4 Awaiting requested review from MattIPv4

Assignees

No one assigned

Labels

add This PR/issue is regarding adding a new subdomain awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain invalid organisation This PR/issue is regarding a target on a GitHub organisation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nmsderp @MattIPv4 @indus