Skip to content

Conversation

ragokan
Copy link
Contributor

@ragokan ragokan commented Oct 24, 2023

Bunicorn is just another JS library for creating servers like express/fastify, but with more Edge support and faster runtime.

@ragokan ragokan changed the title Add bunicorn.js.org bunicorn.js.org Oct 24, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Do you have a link to where we can preview your content prior to merging this PR?

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Oct 24, 2023
@ragokan
Copy link
Contributor Author

ragokan commented Oct 24, 2023

👋 Do you have a link to where we can preview your content prior to merging this PR?

Of course, I added it to 'Content' of the description as link.
You can also see it here: https://bunicorn.vercel.app/

@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed awaiting response This PR is waiting for a response from the requester labels Oct 24, 2023
@indus
Copy link
Member

indus commented Oct 24, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain (currently it also redirects to www.)
I'll merge after we have "contact". Please keep this PR open.

@ragokan
Copy link
Contributor Author

ragokan commented Oct 24, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain (currently it also redirects to www.) I'll merge after we have "contact". Please keep this PR open.

Hello, thank you so much for adding. Looks like it accepted the non www one now, I am not sure what should I do for www, this is my Vercel page, but if still it does not allow www, I can do redirect. Thanks!

SS 2023-10-24 at 18 43 40 SS 2023-10-24 at 18 43 48

@indus
Copy link
Member

indus commented Oct 24, 2023

I'm not familiar with vercel so you will have to figure this out. But I would try to remove the "www" records altogether.

@ragokan
Copy link
Contributor Author

ragokan commented Oct 24, 2023

@indus Since I had some problems with setting it on Vercel, and your docs shows exactly how to do for 'Github Pages', I moved it to Github Pages. Now, the new url is: https://ragokan.com/bunicorn/

I also updated the records on JS file. Thanks for helping!

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 removed add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Oct 24, 2023
@ragokan
Copy link
Contributor Author

ragokan commented Oct 25, 2023

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

Hello, sorry for the confusions, I added it to Pages settings now, domain check is successful, too.

@indus
Copy link
Member

indus commented Oct 25, 2023

I've just changed the target in JS.ORGs zonefile. But I still get the redirect to https://www.bunicorn.js.org/. Maybe it just takes some time to propagate...

@indus
Copy link
Member

indus commented Oct 25, 2023

@ragokan now I get a redirect error. There is something really messed up.
Because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@ragokan
Copy link
Contributor Author

ragokan commented Oct 25, 2023

@ragokan now I get a redirect error. There is something really messed up. Because you are using a workflow to deploy the page, additional steps may be required to
make the CNAME work. FYI: #7853 (comment) / #8532 (comment)

Thanks, I'll search for them.

This is current settings:
SS 2023-10-25 at 18 32 02

@ragokan
Copy link
Contributor Author

ragokan commented Oct 25, 2023

Hello @indus, it is worked now. As you said, for the deploy with CNAME, I had to do this;

Setting the deploy method to "Deploy from branch"
Manually triggering the workflow (for us via workflow_dispatch)
Setting the deploy method back to "GitHub Actions"

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain labels Oct 26, 2023
@indus
Copy link
Member

indus commented Oct 26, 2023

Welcome https://bunicorn.js.org

@indus indus merged commit 186647f into js-org:master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants