twinspark.js.org

[roman-koshchei]

• There is reasonable content on the page (see: No Content)
• I have read and accepted the Terms and Conditions

I should say, that I am not the author of the library.
BUT the author is interested in js.org, so I just help him.
You can check it: github.com/piranha/twinspark-js/issues/23.

[MattIPv4]

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance twinspark.js.org.

[piranha]

@MattIPv4 done :) sorry for the inconvenience!

[indus]

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

[piranha]

Riight I've added that to settings, but there is some problem with HTTPS redirect - it redirects to itself.

[piranha]

For anybody that comes across this. I think you need to do the default GitHub pages deployment with the custom domain set. That gets it setup. You can then flip it back to the GitHub actions deployment.

Ohh I'll try that, re-deploying to check if it helps right now.

[piranha]

Okay I did what that comment says, but I had to be more patient — it started working with Actions workflow while I was waiting for an old-style deploy. :-) I'll revert that stuff back, heh.

[piranha]

Argh :( moving back to actions deploy destroyed it. Wtf :(

[piranha]

twinspark.js.org has address 172.67.73.64
twinspark.js.org has address 104.26.8.84
twinspark.js.org has address 104.26.9.84

I guess those are your IPs, not Github's, right? I'm trying to understand where the issue can be...

[MattIPv4]

Yes, those are Cloudflare IPs, as the domain is proxied through Cloudflare.

[piranha]

I did the whole dance again and it seems to work. But last two commits did not trigger a workflow run, and I have no idea why. 🤣 So I'm wary of declaring this issue a success — it works now, but who knows what will happen when (if?) workflow runs.

[indus]

@piranha the popularity of workflows has made this whole procedure a bit more challenging for us as well. It is not allways clear what causes problems. But after getting it work initially we never heard any complaints from subdomain requesters 🤞
Welcome https://twinspark.js.org

[piranha]

It seems like Github had a hiccup, and now has triggered workflows for all commits and all is well, so 🎉 :-)) Thanks!

It's weird that workflows don't work as well with custom domains, since it seems like old-style way just triggers some built-in workflow...