Skip to content

Conversation

GuptaSiddhant
Copy link
Contributor

@GuptaSiddhant GuptaSiddhant commented Oct 6, 2025

The site content is documentation for a tool to host/manage StoryBooks using own infra/cloud. The tool is called StoryBooker.

@GuptaSiddhant GuptaSiddhant force-pushed the master branch 2 times, most recently from 582d342 to d6304b5 Compare October 6, 2025 10:18
@GuptaSiddhant
Copy link
Contributor Author

Hi @indus , for some reason the CI check is failing for a non-associated domain entry. Could you help me fix this?

@indus
Copy link
Member

indus commented Oct 6, 2025

@GuptaSiddhant

it looks like your PR is changing "sticksy": "kovart.github.io/sticksy", to "sticksy": "kovart.r.io/sticksy",. You just have to revert that change to make the CI check work...

@indus
Copy link
Member

indus commented Oct 6, 2025

@GuptaSiddhant I've just seen you are currently using guptasiddhant.com would you dismiss that with a js.org domain - or what is you plan on this?

@indus indus added the awaiting response This PR is waiting for a response from the requester label Oct 6, 2025
@GuptaSiddhant
Copy link
Contributor Author

@indus , sorry for the rookie mistake. I fixed it.
As for guptasiddhant.com, it should not matter. I previously did the same with https://react-table-ui.js.org and that worked well.

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed awaiting response This PR is waiting for a response from the requester labels Oct 6, 2025
@indus
Copy link
Member

indus commented Oct 6, 2025

@indus , sorry for the rookie mistake. I fixed it.

No problem. I've just added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

As for guptasiddhant.com, it should not matter. I previously did the same with https://react-table-ui.js.org and that worked well.

As long as the js.org subdomain is in active use, presenting the content and not just redirecting to your domain, thats fine. A automatic redirect would raise questions in our yearly cleanup process as it would violate our "reasonable content" requirement.

@GuptaSiddhant
Copy link
Contributor Author

@indus, the workaround worked: https://storybooker.js.org. And removed guptasiddhant.com from custom domain in GitHub.

@MattIPv4 MattIPv4 changed the title add storybooker.js.org storybooker.js.org Oct 6, 2025
@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Oct 7, 2025
@indus
Copy link
Member

indus commented Oct 7, 2025

Welcome https://storybooker.js.org

@indus indus merged commit 825c189 into js-org:master Oct 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants