Skip to content

esdora.js.org #10039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2025
Merged

esdora.js.org #10039

merged 1 commit into from
Aug 3, 2025

Conversation

kkfive
Copy link
Contributor

@kkfive kkfive commented Aug 2, 2025 •
edited
Loading

The site content introduces Esdora, a modern JavaScript utility library that complements established toolkits like Lodash by providing a curated collection of practical, high-quality functions often missing elsewhere.

@kkfive kkfive changed the title 添加 esdora-js.github.io esdora-js.github.io Aug 2, 2025
@MattIPv4 MattIPv4 changed the title esdora-js.github.io esdora.js.org Aug 2, 2025
MattIPv4
MattIPv4 requested changes Aug 2, 2025
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Please can you fill out the PR template/description with information about what your site is, so that we may process your request.

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Aug 2, 2025
@kkfive
Copy link
Contributor Author

kkfive commented Aug 3, 2025

I have updated

@MattIPv4
Copy link
Member

MattIPv4 commented Aug 3, 2025

@kkfive I'm not sure what automation you've enabled, but it has wiped your PR... it is no longer adding any subdomain request to cnames_active.js.

@MattIPv4 MattIPv4 added invalid and removed awaiting response This PR is waiting for a response from the requester labels Aug 3, 2025
@kkfive
Copy link
Contributor Author

kkfive commented Aug 3, 2025

I have resubmitted it.

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain and removed invalid labels Aug 3, 2025
@indus
Copy link
Member

indus commented Aug 3, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line esdora.js.org to make it work. In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)
I'll merge after we have "contact". Please keep this PR open.

@kkfive
Copy link
Contributor Author

kkfive commented Aug 3, 2025

Thank you very much. I have seen that it can be accessed.

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Aug 3, 2025
@indus
Copy link
Member

indus commented Aug 3, 2025

Welcome https://esdora.js.org

@indus indus merged commit 0451573 into js-org:master Aug 3, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkfive @MattIPv4 @indus