Skip to content
This repository was archived by the owner on Jun 22, 2021. It is now read-only.

feat: Improves constructFilter. #6

Merged
merged 2 commits into from
Mar 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ import factory from '@js-entity-repos/express/dist/factory';

const todosFacade = factory<TodoEntity>({
// Optional property that modifies a filter for the service.
constructFilter: (filter) => {
constructFilter: ({ filter, req, res }) => {
// This is a great place to put authentication and authorisation logic.
return filter;
},
// Optional property. Defaults to 10.
Expand Down
4 changes: 2 additions & 2 deletions src/FacadeConfig.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import Facade from '@js-entity-repos/core/dist/Facade';
import Entity from '@js-entity-repos/core/dist/types/Entity';
import Filter from '@js-entity-repos/core/dist/types/Filter';
import FilterConstructor from './utils/FilterConstructor';
import TransactionHandler from './utils/TransactionHandler';

export default interface FacadeConfig<E extends Entity> {
readonly constructFilter: (filter: Filter<E>) => any;
readonly constructFilter: FilterConstructor<E>;
readonly service: Facade<E>;
readonly handleTransaction: TransactionHandler;
readonly defaultPaginationLimit: number;
Expand Down
4 changes: 2 additions & 2 deletions src/FactoryConfig.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import Facade from '@js-entity-repos/core/dist/Facade';
import Entity from '@js-entity-repos/core/dist/types/Entity';
import { Filter } from '@js-entity-repos/core/dist/types/Filter';
import FilterConstructor from './utils/FilterConstructor';
import TransactionHandler from './utils/TransactionHandler';

export default interface FactoryConfig<E extends Entity> {
readonly constructFilter?: (filter: Filter<E>) => any;
readonly constructFilter?: FilterConstructor<E>;
readonly service: Facade<E>;
readonly handleTransaction?: TransactionHandler;
readonly defaultPaginationLimit?: number;
Expand Down
2 changes: 1 addition & 1 deletion src/factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import handleTransaction from './utils/handleTransaction';

export default <E extends Entity>(factoryConfig: FactoryConfig<E>): Router => {
const facadeConfig: FacadeConfig<E> = {
constructFilter: (filter) => filter,
constructFilter: ({ filter }) => filter,
defaultPaginationLimit: 10,
handleTransaction,
...factoryConfig,
Expand Down
3 changes: 2 additions & 1 deletion src/functions/countEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
const { count } = await config.service.countEntities({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
});
res.status(OK).json(count);
});
Expand Down
3 changes: 2 additions & 1 deletion src/functions/getEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ import getNumberQueryParam from '../utils/getNumberQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
const limit = getNumberQueryParam(req.query, 'limit', config.defaultPaginationLimit);
const result = await config.service.getEntities({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
pagination: {
cursor: req.query.cursor,
forward: req.query.forward === 'true',
Expand Down
3 changes: 2 additions & 1 deletion src/functions/getEntity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
const { entity } = await config.service.getEntity({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
id: req.params.id,
});
res.status(OK).json(entity);
Expand Down
3 changes: 2 additions & 1 deletion src/functions/patchEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
const { entity } = await config.service.patchEntity({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
id: req.params.id,
patch: req.body,
});
Expand Down
3 changes: 2 additions & 1 deletion src/functions/removeEntities.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
await config.service.removeEntities({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
});
res.status(NO_CONTENT).send();
});
Expand Down
3 changes: 2 additions & 1 deletion src/functions/removeEntity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
await config.service.removeEntity({
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
id: req.params.id,
});
res.status(NO_CONTENT).send();
Expand Down
3 changes: 2 additions & 1 deletion src/functions/replaceEntity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import getJsonQueryParam from '../utils/getJsonQueryParam';
export default <E extends Entity>(config: FacadeConfig<E>) => {
return async (req: Request, res: Response) => {
await config.handleTransaction({ req, res }, async () => {
const filter = getJsonQueryParam(req.query, 'filter');
const { entity } = await config.service.replaceEntity({
entity: req.body,
filter: config.constructFilter(getJsonQueryParam(req.query, 'filter')),
filter: config.constructFilter({ filter, req, res }),
id: req.params.id,
});
res.status(OK).json(entity);
Expand Down
13 changes: 13 additions & 0 deletions src/utils/FilterConstructor.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import Entity from '@js-entity-repos/core/dist/types/Entity';
import { Filter } from '@js-entity-repos/core/dist/types/Filter';
import { Request, Response } from 'express';

export interface Opts<E extends Entity> {
readonly req: Request;
readonly res: Response;
readonly filter: Filter<E>;
}

type FilterConstructor<E extends Entity> = (opts: Opts<E>) => Filter<E>;

export default FilterConstructor;