-
Notifications
You must be signed in to change notification settings - Fork 30
implement CESU-8 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement CESU-8 #44
Conversation
src/org/jcodings/transcode/specific/From_CESU_8_Transcoder.java
Outdated
Show resolved
Hide resolved
|
Something in here is not right and causes failures in JRuby. I attempted to use a master snapshot in a test CI on JRuby and ended up with the following errors: |
|
I will revert for now and we can try to figure out what broke. It's possible the tests are bad or not up-to-date for CESU-8. |
|
Ah automatic revert is not possible due to other changes that have landed (like my toUnsigned changes). We should not release until we can address the failures. |
|
this test is definitely outdated https://bugs.ruby-lang.org/issues/16922 not sure about the second one, I'll take a look |
|
Ok as I suspected. I have started a PR to update the test on master and requested that the change and test patches be backported to CRuby 2.6 (though they probably won't do it). |
https://bugs.ruby-lang.org/issues/15931
jruby/jruby#6464