Button Re-write #1513
Closed
Button Re-write #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| direction: "horizontal", | ||
| excludeInvisible: true, | ||
| classes: {} |
Gets rid of the double negative.
IE8 is inconsistent in outputting space through .html() and .text() methods, but since it renders it correctly, we can just ignore it.
In IE8, the empty elements cause issues. Adding text content makes sense, since empty elements are useless.
This was already toggled in _toggleClasses, but that isn't called on create.
arschmitz
force-pushed
the
button-fixup
branch
from
e09f425 to
e84b815
Compare
|
Landed in master 6e70f94...52d9ec6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1415