Button classes #1415
Button classes #1415
Conversation
| } | ||
| } | ||
| return radios; | ||
| // We find .ui-button first then filer by :ui-button because doing a |
There was a problem hiding this comment.
Typo, "filter" should be "filter". Also drop the "a" at the end.
|
Leftovers from #1333:
There are some more comments, most of them resolved, except for the discussion about selectmenu width:
|
|
|
||
| <div class="demo-description"> | ||
| <p>Examples of the markup that can be used for buttons: A button element, an input of type submit and an anchor.</p> | ||
| <p>Buttons can be styled via the button widget for by adding the classes yourself to avoid the javascript overhead if you dont need any of the methods provided by the button widget</p>p> |
There was a problem hiding this comment.
Bad markup, delete the p> at the end of the line
Yes it does that was fixed in #1333 and here see https://github.com/jquery/jquery-ui/pull/1333/files#r22649864
Not with our browser support its not possible
Pushed commit already arschmitz@9afd80b |
| </button> | ||
| <button class="ui-button ui-widget ui-corner-all ui-icon-bottom"> | ||
| <span class="ui-icon ui-icon-triangle-1-s"></span> | ||
| Button with icon on bottom |
There was a problem hiding this comment.
"Button with icon on the bottom", to make it consistent with the text above
Okay, I misread the code. Using "change" seems fine, but why the separate handler instead of using the Also replacing the alert with appending some text to the page would be good. |
| <legend>Filter by location: </legend> | ||
| <label for="location-new-york">New York</label> | ||
| <input type="radio" name="location" id="location-new-york"> | ||
| <label>Paris |
There was a problem hiding this comment.
Why is this mixing "input inside label" with other variants? Doesn't belong in a demo.
|
@jzaefferer regarding the layout issues in the demos looks like this happened when i rebased with master and the demo font size changed ill go through them all and check the layouts |
| } | ||
| }).selectmenu( "widget" ).removeClass( "ui-icon-end" ); | ||
| $( ".controlgroup" ).controlgroup(); | ||
| $( "select" ).on( "selectmenuchange", function(){ |
There was a problem hiding this comment.
Should convert this to the change option as part of the .selectmenu() call.
arschmitz
force-pushed
the
button-classes
branch
from
f81f0ca to
992a69f
Compare
Replaced by gh-1513
Updates the previous button pr #1333 to the new _add/_remove/_toggleClass api
Of note is a significant re-thinking and simplification of the logic in controlgroup.