fix docker #198
Merged
fix docker #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Jul 12, 2024
README.md
Outdated
| ```bash | ||
| cd docker | ||
| docker build -f ./docker/Dockerfile -t local_lab_env . | ||
| docker build -f ./Dockerfile -t local_lab_env . |
Owner
There was a problem hiding this comment.
This instructs the user to build the outermost docker file, which is not required. I would suggest reverting this.
Contributor
Author
There was a problem hiding this comment.
It is duplicated. One of the following works.
cd docker
docker build -f ./Dockerfile -t local_lab_env .
docker build -f ./docker/Dockerfile -t local_lab_env .
Owner
There was a problem hiding this comment.
Right. I would then go for:
- remove the cd
- Use the original instruction
Reasoning behind this is that then the context of the Dockerfile is the root of the repo
jorgensd
reviewed
Jul 12, 2024
| RUN curl -sL https://deb.nodesource.com/setup_18.x -o nodesource_setup.sh && \ | ||
| bash nodesource_setup.sh && \ | ||
| apt install nodejs | ||
| apt -y install nodejs |
jorgensd
reviewed
Sep 26, 2024
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to build the Docker image with the Dockerfile in the docker/ directory. There are some problems, and I am still working on them.
It works now.