Updated for iOS #310
Merged
Updated for iOS #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not working in iPhone due to presence of charset utf-8
|
Thank you for your PR, apologies for the delayed review |
This was referenced Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some server types, specifically Apache Tomcat, the addition of 'charset=utf-8' to the content-type headers is not required on iOS in case of multipart/form-data and causes the server to ignore files in case that's what the multipart content contains.
On Android, the content-type header doesn't carry this additional parameter.
Removing it from iOS now. In case this is required for a specific type of multipart content then we should discuss it and write additional conditions for the same.