Fix microsoft/TypeScript#27864 #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeywatts
force-pushed
the
esnext-private-instance-fields
branch
3 times, most recently
from
f833ce0 to
666a02c
Compare
Moves the transformation of class properties to the ESNext transformer.
Property initializers are moved to the constructor by the TypeScript transformer only if there is constructor parameter properties. This is to preserve property initialization order.
It currently does not produce void 0 initializers for property declarations that have no initializer due to ESNext and TypeScript having different runtime behaviors. TS completely elides property declarations with no initializer, while I believe the ESNext would define that property on the instance with an undefined value (which is observable at runtime - propertyName in instance or for (var prop in instance) {}).
joeywatts
force-pushed
the
hoist-block-level
branch
from
1235aae to
2d992e1
Compare
joeywatts
changed the base branch from
esnext-private-instance-fields
to
class-properties-esnext
Signed-off-by: Joseph Watts <[email protected]>
Signed-off-by: Max Heiber <[email protected]>
joeywatts
force-pushed
the
hoist-block-level
branch
from
2d992e1 to
3e212e6
Compare
I couldn't get the evaluator.evaluateTypeScript function to do codegen when there is a syntax error, even with the `noEmitOnError: false` compiler option. Signed-off-by: Max Heiber <[email protected]>
Signed-off-by: Joseph Watts <[email protected]>
joeywatts
force-pushed
the
hoist-block-level
branch
from
3e212e6 to
a58f29b
Compare
|
Closing (opened bloomberg#14) |
joeywatts
pushed a commit
that referenced
this pull request
Jan 23, 2019
Transform private named instance fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes binding of computed property names and provides a mechanism to hoist things at a block-level.