Revert "Add Classifiers to Setup.py" #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickhanlonii can you review? |
|
Looks good. |
jaitaiwan
added a commit
that referenced
this pull request
Aug 19, 2015
Revert "Add Classifiers to Setup.py"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having merged to master we have to do one of the following:
a) Rebase develop and screw everyone's downstream develop branches; or:
b) Merge master into develop, possibly causing merge conflicts and cause regressions; or:
c) Patch both develop and master with the change, causing a (easier to solve) merge conflict between master and develop when making a release active
My suggestion is that we revert the change, make sure the pull request is made against the develop branch and rebase the release/1.9 branch on top making the chance of regression, and angry downstream contributors very unlikely.