Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Pilot service account and RBAC policy #162

Merged
merged 1 commit into from
Jan 17, 2018
Merged

Pilot service account and RBAC policy #162

merged 1 commit into from
Jan 17, 2018

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Nov 30, 2017

  • Add a service account for Pilots
  • and a corresponding RBAC policy which allows pilots to update their pilot resources.

Fixes: #161
Release note:

NONE

@wallrj
Copy link
Member Author

wallrj commented Nov 30, 2017

/test e2e

@munnerz
Copy link
Contributor

munnerz commented Dec 1, 2017

/test all

@wallrj wallrj force-pushed the 161-pilot-privileges branch from a663c05 to 82f5d61 Compare December 13, 2017 17:48
@wallrj wallrj changed the base branch from 23-cassandra to master December 13, 2017 17:48
@wallrj wallrj changed the title Pilot service account and RBAC policy WIP: Pilot service account and RBAC policy Dec 14, 2017
@wallrj wallrj mentioned this pull request Dec 14, 2017
Merged
@wallrj wallrj force-pushed the 161-pilot-privileges branch from 82f5d61 to e56a66a Compare December 14, 2017 11:16
@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@munnerz munnerz added this to the v0.1 milestone Jan 13, 2018
@wallrj wallrj force-pushed the 161-pilot-privileges branch from e56a66a to 5f86ee2 Compare January 16, 2018 14:24
@wallrj
Copy link
Member Author

wallrj commented Jan 16, 2018

/test e2e

@wallrj wallrj force-pushed the 161-pilot-privileges branch from 5f86ee2 to 39c0767 Compare January 17, 2018 17:20
@wallrj wallrj changed the title WIP: Pilot service account and RBAC policy Pilot service account and RBAC policy Jan 17, 2018
@wallrj wallrj changed the title Pilot service account and RBAC policy WIP: Pilot service account and RBAC policy Jan 17, 2018
@wallrj wallrj force-pushed the 161-pilot-privileges branch from 39c0767 to 99fab98 Compare January 17, 2018 17:33
@wallrj wallrj changed the title WIP: Pilot service account and RBAC policy Pilot service account and RBAC policy Jan 17, 2018
munnerz
munnerz approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/controllers/cassandra/testing/testing.go
f.t.Fatal(err)
}
return roleBindings
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR - but it'd be great if we can make these sorts of things generic between controllers.

If we define a RoleBindingsFixture struct, and embed it within the Fixture struct for each controller we can plug and play different test fixture pieces potentially.

Something to think about 😄

@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@munnerz
Copy link
Contributor

munnerz commented Jan 17, 2018

/retest

@munnerz
Copy link
Contributor

munnerz commented Jan 17, 2018 •
edited
Loading

From looking at the logs from the 1.9 failure, it seems there may be a bug in either genericpilot or Elasticsearch pilot that is causing it not to sync as often as it should (logs: https://storage.googleapis.com/jetstack-logs/pr-logs/pull/jetstack_navigator/162/navigator-e2e-v1-9/90/artifacts/test-elasticsearchcluster-1516211071-11552/dump.

The pilot wasn't being synced for >1m, causing it to not update the document count on time.

ref #212

@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@wallrj
Pilot service account and RBAC policy
4c2dcba 
* Add a service account for Pilots
* and a corresponding RBAC policy which allows pilots to update their pilot resources.

Fixes: jetstack#161
@munnerz munnerz force-pushed the 161-pilot-privileges branch from 99fab98 to c8b9067 Compare January 17, 2018 20:48
@jetstack-ci-bot
Copy link
Contributor

/lgtm cancel //PR changed after LGTM, removing LGTM. @munnerz @wallrj

@wallrj wallrj force-pushed the 161-pilot-privileges branch from c8b9067 to 4c2dcba Compare January 17, 2018 20:51
@wallrj
Copy link
Member Author

wallrj commented Jan 17, 2018

/retest

@munnerz
Copy link
Contributor

munnerz commented Jan 17, 2018

/test all

@munnerz munnerz added the lgtm label Jan 17, 2018
@jetstack-ci-bot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@jetstack-ci-bot
Copy link
Contributor

Automatic merge from submit-queue.

@jetstack-ci-bot jetstack-ci-bot merged commit e87a3a6 into jetstack:master Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@munnerz munnerz munnerz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@munnerz munnerz

Labels

approved area/cassandra lgtm release-note-none size/XL

Projects

None yet

Milestone

v0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@wallrj @munnerz @jetstack-ci-bot @jetstack-bot