-
Notifications
You must be signed in to change notification settings - Fork 2
Build and push the hourly billing agent ubbagent #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6736af to
08817d4
Compare
08817d4 to
84b3806
Compare
Signed-off-by: Maël Valais <[email protected]> Co-authored-by: Richard Wall <[email protected]>
84b3806 to
cc031c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments and questions, but please merge at will.
| args: | ||
| - push | ||
| - gcr.io/$PROJECT_ID/${_SOLUTION_NAME}/ubbagent:${_CERT_MANAGER_VERSION} | ||
| waitFor: ["build-ubbagent"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered if these commands could all be executed in a single step, assuming that the gcr.io/cloud-builders/gcloud has the docker cli tools.
It might simplify the (already rather long) cloud-build.yaml.
But happy for this to be merged now, if you prefer it this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another question is whether we can pull / tag and push an existing image, rather than building from scratch?
Or even whether we need to pull and push this image, if by chance it is already hosted on the marketplace gcr registry.
These are just idle thoughts. Ignore them if you want to just get this merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i would be happy to justn one single step instead of scattering in 3 different steps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And another question is whether we can pull / tag and push an existing image, rather than building from scratch?
I was unable to find a blessed image on gcr.io unfortunately, I searched everywhere but could not find anything :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the gcloud doesnt have docker 😞
Step #12 - "build-ubbagent": + git clone https://github.com/GoogleCloudPlatform/ubbagent --branch 0.0.1
Step #12 - "build-ubbagent": + docker build --tag gcr.io/jetstack-mael-valais/cert-manager/ubbagent:1.1.0 ./ubbagent
Step #12 - "build-ubbagent": bash: line 1: docker: command not found
ed64a6e to
cc031c9
Compare
Signed-off-by: Maël Valais <[email protected]> Co-authored-by: Richard Wall <[email protected]>
|
Oops, some of my latest changes broke |
Signed-off-by: Maël Valais <[email protected]>
|
Fixed! I had to move the preflight folder to the /unassign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @maelvls
Closes #7.
I simply clone the GoogleCloudPlatform/ubbagent repo and built the image using the given
./Dockerfilein ourcloudbuild.yml. The image is then pushed to:# I use my own project, jetstack-mael-valais, for testing: gcr.io/jetstack-mael-valais/ubbagent:1.1.0Since we just need the basic hourly reporting in the first iteration, I think it's OK not to fork it right away (no need to customize it at the moment).