Skip to content

Fix schema yaml too large #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2021
Merged

Fix schema yaml too large #43

merged 3 commits into from
Mar 31, 2021

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Mar 27, 2021 •
edited
Loading

In an email from Dinesh:

Your schema.yaml is too large -- can you please clear comments from schema.yaml file repo, build the new deployer image and resubmit the draft for review. This should get the file below the 16384 size limit.

I removed a couple of comments in order to go under 16384 bytes... 😆

maelvls added 2 commits March 27, 2021 11:14
@maelvls
schema.yaml: rm comments, now is 16273 bytes (limit: 16384)
24a78c3 
From Google:

> Your schema.yaml is too large -- can you please clear comments
> from schema.yaml file repo, build the new deployer image and
> resubmit the draft for review. This should get the file below
> the 16384 size limit.

Signed-off-by: Maël Valais <[email protected]>
@maelvls
bump to 1.1.0-gcm.7
61219f6 
Signed-off-by: Maël Valais <[email protected]>
@maelvls maelvls changed the base branch from main to fix-missing-notes March 27, 2021 10:30
@maelvls maelvls requested a review from wallrj March 27, 2021 10:31
@maelvls
docs: fix the notes
c96aa81 
Signed-off-by: Maël Valais <[email protected]>
@maelvls maelvls added this to the initial-release milestone Mar 30, 2021
wallrj
wallrj approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ curl --silent https://raw.githubusercontent.com/jetstack/jetstack-secure-gcm/c96aa816c8ee0d8c710560bf3ddc69b31add8c32/schema.yaml | wc  -c
16273

/lgtm

@maelvls maelvls merged commit 7218cdf into fix-missing-notes Mar 31, 2021
@maelvls maelvls deleted the fix-schema-yaml-too-large branch March 31, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels

lgtm size/S

Projects

None yet

Milestone

initial-release

Development

Successfully merging this pull request may close these issues.

4 participants

@maelvls @wallrj @jetstack-bot