Skip to content

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Mar 4, 2021

As part of #29, I had to disable the re-tagging/re-pushing of all the images in cloudbuild.md is that we do not want to 'override' the OSPO-approved (open source program office) that are currently in the registry.

In order to retag all google-review images to 1.1.0-gcm.1 since we don't have yet automated Google-OSPO-compliant image (automation will be done in #10):

while read img; do
    docker pull $img:google-review
    docker tag $img:{google-review,1.1.0-gcm.1}
    docker push $img:1.1.0-gcm.1
done <<EOF
gcr.io/jetstack-public/jetstack-secure-for-cert-manager
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-acmesolver
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-cainjector
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-webhook
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/cert-manager-google-cas-issuer
gcr.io/jetstack-public/jetstack-secure-for-cert-manager/preflight
EOF

As part of this PR, I also documented all the intricacies about the deployer tag.

@maelvls maelvls changed the title Disable re-tagging due to the licenses requirements Disable retagging in cloudbuild.yaml due to the licenses requirements Mar 5, 2021
@maelvls maelvls force-pushed the use-jetstack-public-to-build branch from 3808b23 to 024df61 Compare March 5, 2021 09:35
@maelvls maelvls force-pushed the use-jetstack-public-to-build branch from 024df61 to d375fbe Compare March 5, 2021 09:36
Signed-off-by: Maël Valais <[email protected]>
@maelvls maelvls self-assigned this Mar 5, 2021
@maelvls maelvls added this to the initial-release milestone Mar 5, 2021
@maelvls maelvls linked an issue Mar 5, 2021 that may be closed by this pull request
Comment on lines -29 to +32
resources:
limits:
cpu: 200m
memory: 200Mi
requests:
cpu: 200m
memory: 200Mi
resources: {}
# requests:
# cpu: 10m
# memory: 32Mi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth having a look at how we are supposed to be setting the request and limit fields. I had to remove the resource request for the google-cas-issuer due to the smoke-test clsuter single node being too small, but I don't really know how we should do things with regards to the Marketplace UI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-w
Copy link
Contributor

james-w commented Mar 5, 2021

/lgtm

@jetstack-bot jetstack-bot merged commit 26626bf into main Mar 5, 2021
@maelvls maelvls deleted the use-jetstack-public-to-build branch March 5, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the smoke-test tester image

4 participants