-
Notifications
You must be signed in to change notification settings - Fork 2
Disable retagging in cloudbuild.yaml due to the licenses requirements #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: Maël Valais <[email protected]>
3808b23 to
024df61
Compare
Signed-off-by: Maël Valais <[email protected]>
024df61 to
d375fbe
Compare
Signed-off-by: Maël Valais <[email protected]>
| resources: | ||
| limits: | ||
| cpu: 200m | ||
| memory: 200Mi | ||
| requests: | ||
| cpu: 200m | ||
| memory: 200Mi | ||
| resources: {} | ||
| # requests: | ||
| # cpu: 10m | ||
| # memory: 32Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth having a look at how we are supposed to be setting the request and limit fields. I had to remove the resource request for the google-cas-issuer due to the smoke-test clsuter single node being too small, but I don't really know how we should do things with regards to the Marketplace UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
/lgtm |
As part of #29, I had to disable the re-tagging/re-pushing of all the images in cloudbuild.md is that we do not want to 'override' the OSPO-approved (open source program office) that are currently in the registry.
In order to retag all
google-reviewimages to1.1.0-gcm.1since we don't have yet automated Google-OSPO-compliant image (automation will be done in #10):As part of this PR, I also documented all the intricacies about the deployer tag.