Feed: Temp replace taskSeq with asyncSeq #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordfjord
commented
May 15, 2023
Contributor
Author
There was a problem hiding this comment.
Note, this was mostly for me as the azure pipeline doesn't run any of the test suites. This pipeline ran to success on my fork as I have some free minutes from GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a resource leak in task seq that has been causing us a lot of heartache.
This change is made to be as small as possible so we're still using IAsyncEnumerables but wrap them in AsyncSeq to avoid the resource leaks introduced by the TaskSeqBuilder