fix: distribute rest files over shards #13476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Oct 19, 2022
Member
SimenB
left a comment
SimenB
left a comment
There was a problem hiding this comment.
can you add a changelog entry?
also, ESLint with type info is unhappy 🙂 run yarn lint-ts-files locally to see
SimenB
reviewed
Oct 19, 2022
Co-authored-by: Simen Bekkhus <[email protected]>
SimenB
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sharding breaks execution by producing groups of length 0.
This was caused b naively using
Math.ceilto determine the uniform shard size; this affects cases where bothn % Math.ceil(n / s) === 0andn % s !== 0are true (nis number of tests,sis chosen shard count).