fix(valid-describe): report on concise-body arrow functions #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
referenced
this pull request
in Esri/calcite-design-system
Jul 21, 2021
G-Rath
changed the title
G-Rath
approved these changes
Jul 21, 2021
Collaborator
G-Rath
left a comment
G-Rath
left a comment
There was a problem hiding this comment.
good catch - we should have always supported this tbh
Contributor
Author
|
Awesome, thanks for the quick review and merge! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
## [24.3.7](v24.3.6...v24.3.7) (2021-07-21) ### Bug Fixes * **valid-describe:** report on concise-body arrow functions ([#863](#863)) ([71c5299](71c5299))
|
🎉 This PR is included in version 24.3.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jest 27 will throw an error if a describe block returns a value (changelog, test-case). This PR updates
valid-describeto report on these instances that would fail tests.If deemed useful, I could look at making this fixable in a follow-up PR.