Skip to content

Conversation

stefanhaller
Copy link
Collaborator

The cursor is a bit of a security concern, because it reveals the length (and typing pattern) of the password.

Resolves #4877.

@stefanhaller stefanhaller added the bug Something isn't working label Sep 6, 2025
Copy link

codacy-production bot commented Sep 6, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6941b811 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6941b81) Report Missing Report Missing Report Missing
Head commit (851afe9) 57739 50195 86.93%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4878) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@heysokam
Copy link

heysokam commented Sep 6, 2025

Would it be possible for the behavior to be a configurable option?
While it is a security concern in certain situations, I can see the usefulness of seeing where your cursor lies while typing in regular situations.
So I can imagine this being a non-issue for most people.

Maybe having a configuration option could be the best of both worlds? 🤔

@stefanhaller
Copy link
Collaborator Author

I don't think that's necessary. While it might seem strange at first that you don't get any visual feedback that you are typing something, that's the point after all. And if you get a password prompt on the console, you don't see anything either. I think that's ok.

The cursor is a bit of a security concern, because it reveals the length (and
typing pattern) of the password.
@stefanhaller stefanhaller force-pushed the hide-cursor-in-password-prompt branch from 235f413 to 851afe9 Compare September 20, 2025 09:12
@stefanhaller stefanhaller merged commit cb2b5c3 into master Sep 20, 2025
12 checks passed
@stefanhaller stefanhaller deleted the hide-cursor-in-password-prompt branch September 20, 2025 09:14
karolzwolak pushed a commit to karolzwolak/lazygit that referenced this pull request Sep 27, 2025
The cursor is a bit of a security concern, because it reveals the length
(and typing pattern) of the password.

Resolves jesseduffield#4877.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants