Skip to content

Conversation

@jiangzidong
Copy link
Contributor

@jiangzidong jiangzidong commented Apr 27, 2017

If the native pointer's free callback is NULL, we should not call it.

JerryScript-DCO-1.0-Signed-off-by: Zidong Jiang [email protected]

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@akosthekiss akosthekiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosthekiss akosthekiss added bug Undesired behaviour ecma core Related to core ECMA functionality labels Apr 27, 2017
@yichoi yichoi merged commit 14c455b into jerryscript-project:master Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Undesired behaviour ecma core Related to core ECMA functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants