ci: remove tox framework #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnazh
reviewed
Jan 17, 2022
jenstroeger
commented
Jan 18, 2022
behnazh
approved these changes
Jan 18, 2022
|
@behnazh, I just ran this branch in a Python 3.11 environment and it worked just fine (except |
jenstroeger
force-pushed
the
remove-tox
branch
from
ec7f2d1 to
9a731a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the conversation in issue #100.
This package template supports Python 3.9, 3.10, and also 3.11 virtual environments on Linux, Mac, and Windows platforms. Unit testing is currently orchestrated using tox for Python 3.9 and 3.10, we haven’t added 3.11 yet. However, considering PR #99 we’re expanding our CI test matrix across different Python versions and platforms, it doesn’t make sense to run tests against multiple Python versions locally and in CI.
And so we’re now removing tox and run unit tests locally in whichever Python venv the user chooses to work, and without expecting the user to have other Python versions available.