-
Notifications
You must be signed in to change notification settings - Fork 33
Fix #183 #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #183 #184
Conversation
|
Thank you. Can confirm C++17 nested namespaces can now be colored uniformly using |
|
Well I was just going to add support for localized scope resolution names. I did that, but then the tests were broken for function calls, and then for function definitions. So I updated function calls and definitions (got rid of the legacy versions), then there was a minor problem with templated functions so I tweaked the A lot of tag names changed, and in general a lot of core patterns changed so this commit definitely could use your review. Sorry that it's one giant commit. The change could still use cleaning up, I think there are still some legacy function patterns hanging around. |
|
One known regression is the type-casting operators are now marked as templated function calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good! Just some naming and styling nitpicks.
|
Oh I guess one of the last changes I made fixed the type casting ¯_(ツ)_/¯ |

This adds namespace aliases and moves the namespace name into the namespace head pattern.
Namespace Alias:
this tags
namespace name = qualified-namespace ;asmeta.declaration.namespace.aliaswith appropriate scopes for each component.Namespace blockFinderFor changes:
with namespace aliases, the only meaning on
namespacenow is the start of a namespace block. This means that the start pattern of the namespace blockfinder for can be simplified to just a bound /namespace/. The tagging of namespaces was moved into the head includes.@alekseyt this should allow you to target
scopedinnamespace scoped::namespace {}withmeta.head.namespace.cpp entity.name.type.namespace.scope-resolution.cpp