Skip to content

[Pallas:SC] Add support for neg_p, abs_p. #33610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 2, 2025
+9 −5
Merged

[Pallas:SC] Add support for neg_p, abs_p. #33610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions jax/_src/pallas/mosaic/lowering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2779,7 +2779,7 @@ def _rem_lowering_rule(ctx: LoweringRuleContext, x, y):
raise NotImplementedError(aval_out.dtype)


@register_lowering_rule(lax.abs_p)
@register_lowering_rule(lax.abs_p, kernel_types=[*tpu_core.KernelType])
def _abs_lowering_rule(ctx: LoweringRuleContext, x):
(aval_out,) = ctx.avals_out
if jnp.issubdtype(aval_out.dtype, jnp.integer):
Expand All @@ -2789,7 +2789,9 @@ def _abs_lowering_rule(ctx: LoweringRuleContext, x):
raise NotImplementedError(aval_out.dtype)


@register_lowering_rule(lax.neg_p, ensure_mlir_values=False)
@register_lowering_rule(
lax.neg_p, kernel_types=[*tpu_core.KernelType], ensure_mlir_values=False
)
def _neg_lowering_rule(ctx: LoweringRuleContext, x):
(x_aval,) = ctx.avals_in
new_ctx = ctx.replace(
Expand Down
8 changes: 5 additions & 3 deletions tests/pallas/tpu_sparsecore_pallas_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1614,14 +1614,16 @@ def kernel(in_ref, o_ref, scratch_ref):

np.testing.assert_array_equal(f(x), x)

def test_exp(self):
@parameterized.named_parameters(
("exp", jnp.exp), ("neg", lambda x: -x), ("abs", jnp.abs))
def test_unary_ops(self, op):
if not jtu.if_cloud_tpu_at_least(2025, 11, 30):
self.skipTest("Test requires a newer libtpu")

x = jnp.arange(8, dtype=jnp.float32)

def sc_exp_kernel(x_hbm_ref, out_ref):
out_ref[...] = jnp.exp(x_hbm_ref[...])
out_ref[...] = op(x_hbm_ref[...])

result = pl.pallas_call(
sc_exp_kernel,
Expand All @@ -1630,7 +1632,7 @@ def sc_exp_kernel(x_hbm_ref, out_ref):
),
out_shape=x,
)(x)
np.testing.assert_array_equal(result, jnp.exp(x))
np.testing.assert_array_equal(result, op(x))

@parameterized.product(dtype=[np.int32, np.float32])
def test_vector_gather(self, dtype):
Expand Down
Loading