Skip to content

Conversation

@Abinesh-Mathivanan
Copy link

I found these two issues while reading the repo,

  1. The experimental fusion module relies on oryx, but it was not listed as a dependency. I've added it to pyproject.toml under a new [project.optional-dependencies.experimental] group to make the dependency explicit for users of this feature.
  2. The compile_ttir_to_hsaco_inplace function created a temporary file for the HSACO binary but never deleted it. I have wrapped the kernel instantiation in a try...finally block to ensure os.remove() is called on the temporary file, preventing a resource leak.

@google-cla
Copy link

google-cla bot commented Jun 26, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant