-
Notifications
You must be signed in to change notification settings - Fork 30
Fixed grammatical errors and the like. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ammbra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
| ## Setting up a Java Development Kit | ||
|
|
||
| You can download the JDK from different places. There is a one-stop page that always refers to the latest version of the JDK: https://jdk.java.net/. Selecting the latest "Ready for use" JDK version takes you to a page where you can download the version of the JDK you need. | ||
| You can download the JDK from different places. [This](https://jdk.java.net/) is a one-stop page that always refers to the latest version of the JDK. Selecting a JDK version listed under the label, "Ready for use" redirects you to a page where you can download the version of the JDK you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about the idea of using a masked link here. Having the full link shown as text comes with the advantage that users could see the link directly without having to hover over or click it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted changes on Line 97
Replace second sentence with revised version from original commit.
|
@gchang12 Was it your intention to close this PR when you deleted your fork? |
Sorry. It must have been closed automatically. This was not my intention, in any case. |
|
If you still want to contribute that change, I think you'd have to open a new PR (and not delete your fork/branch until it's merged). |
Thank you for the tip. I'll do just that. |
No description provided.