Skip to content

Conversation

@gchang12
Copy link

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 14, 2025
@ammbra ammbra self-requested a review October 15, 2025 12:48
Copy link
Collaborator

@ammbra ammbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

## Setting up a Java Development Kit

You can download the JDK from different places. There is a one-stop page that always refers to the latest version of the JDK: https://jdk.java.net/. Selecting the latest "Ready for use" JDK version takes you to a page where you can download the version of the JDK you need.
You can download the JDK from different places. [This](https://jdk.java.net/) is a one-stop page that always refers to the latest version of the JDK. Selecting a JDK version listed under the label, "Ready for use" redirects you to a page where you can download the version of the JDK you need.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about the idea of using a masked link here. Having the full link shown as text comes with the advantage that users could see the link directly without having to hover over or click it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Author

@gchang12 gchang12 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been fixed.

2e3d50e
d5f0204

Reverted changes on Line 97
Replace second sentence with revised version from original commit.
@gchang12 gchang12 closed this by deleting the head repository Oct 25, 2025
@danthe1st
Copy link
Contributor

@gchang12 Was it your intention to close this PR when you deleted your fork?

@gchang12
Copy link
Author

@gchang12 Was it your intention to close this PR when you deleted your fork?

Sorry. It must have been closed automatically. This was not my intention, in any case.

@danthe1st
Copy link
Contributor

danthe1st commented Oct 25, 2025

If you still want to contribute that change, I think you'd have to open a new PR (and not delete your fork/branch until it's merged).

@gchang12
Copy link
Author

If you still want to contribute that change, I think you'd have to open a new PR (and not delete your fork/branch until it's merged).

Thank you for the tip. I'll do just that.

gchang12 added a commit to gchang12/devjava-content that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants