Update JAVACMD in universalJavaApplicationStub.sh #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Java 1.8 is old and no more supported, running this up on new new Java versions doesn't work. To fix the issue the user is forced to install Java 8 which override the existing new Java. With this new ENV var, we can install Java 1.8 in a dedicated folder without polluting our JAVA_HOME or our PATH. Then, add a new environment variable JAVA_HOME_V8 that point to the Java 1.8 home.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to make it easy to run this application on new machines without installing java 1.8 globally:
As Java 1.8 is old and no more supported, running this up on new new Java versions doesn't work.
To fix the issue the user is forced to install (zip) Java 8 which override the existing new Java. With this new ENV var, we can install Java 1.8 in a dedicated folder without polluting our JAVA_HOME or our PATH.
Then add a new environment variable JAVA_HOME_V8 that point to the Java 1.8 home.