Colorblind friendlier palettes #5986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandenman
reviewed
Aug 12, 2025
Comment on lines
+30
to
+34
| { label: qsTr("Colorblind #3"), value: "colorblind3" }, | ||
| { label: qsTr("Colorblind #4"), value: "colorblind4" }, | ||
| { label: qsTr("Viridis"), value: "viridis" }, | ||
| { label: qsTr("Inferno"), value: "inferno" }, | ||
| { label: qsTr("JASP"), value: "jaspPalette" }, |
There was a problem hiding this comment.
I'm not sure if the naming makes sense here. Why not do Colorblind 1 through n and we mention elsewhere that this was different before version XXX? Also, please consistently use tabs for the indents instead of spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: jasp-stats/jaspGraphs#118
I want users to switch to colorblind friendlier palettes.
This is why I would like to make Colorblind #3 the new default at the very top.
To ensure backwards compatibility, I kept Colorblind and Colorblind #1
Yet, they are marked as deprecated and moved to the very bottom.
Maybe this is not the optimal solution yet, so feel free to fix/build on my current proposal.