Skip to content

Conversation

@daniel-tucano
Copy link

now .filter method allow operator and clearPreviousFilters optional properties. operator define what concatenation word will be used between fragments and clearPreviousFilters controls the method behaviour when filter its called more then once, if the provided value is true then clean all previous filter fragments when called again from the same QueryBuilder object, if the provided value is false then do not clean previous filters when called again .clearPreviousFIlters default value is true and operator default value is 'and'

… "operator" and "clearPreviousFilters" optional properties. "operator" define what concatenation word will be used between fragments and "clearPreviousFilters" controls the method behaviour when filter its called more then once ."clearPreviousFIlters" default value is true and "operator" default value is 'and'
@@ -1,3 +1,2 @@
.vs/
dist/
Copy link
Owner

@jaredmahan jaredmahan Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you want the dist folder in source control?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm has a configuration that allow for reference a package from source control (https://blog.npmjs.org/post/154387331670/the-right-tool-for-the-job-why-not-to-use-version.html). I must admit that i dont remember if having dist folder on source control was needed, but at the time a did it

Copy link
Owner

@jaredmahan jaredmahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add back the dist I would be good mergin this PR. Thanks for updating the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants