Workarounds for stack overflows on Windows when using ifort #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll take a look (and also see if I see any other places this might be an issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed a couple of issues with large temporary strings inside of json-fortran causing stackoverflows on Windows builds with ifort. Basically all places where a string that could be very large (e.g. the entire JSON representation as one string) ends up in a temporary could overflow the stack.
I have workarounds in two places in this pull request. For our usage, that resolved the issues on Windows builds with iforts. I did not go through the rest of the codebase to scan for similar places that might be prone to overflowing.