Testing refactor switch merge #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: move emitters to last thing in the method * fix: setImmediate everything
…#222) * chore: update deps * feat: support dial to peerId and/or multiaddr in adition to peerInfo * chore: update CI
* feat: increase maxListeners to Infinity ipfs/js-ipfs-bitswap#142 (comment) * fix linting
* chore: update gitignore and CI * chore: update deps * test: update tests to new p2p-webrtc-star multiaddr format
* fix: resolve transport sort order in browsers * fix: update sort logic
* fix: dont use peerinfo distinct * refactor: remove unneeded code * refactor: clean up * refactor: fix feedback
* stats - stat - prevent 0ms timeDiff breaking movingAverage * chore: remove commitlint
Until we can properly validate the observed address our peer tells us about, we shouldnt blindly add it to our address list. Until we have better NAT management we cant reliably validate that we're adding an appropriate address for ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.