Implement implicit conversion, lazy loading and some performance improvements for netCDF backend #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y instead of a python scalar (`int` or `float`)
DaanVanVugt
approved these changes
Feb 5, 2025
Collaborator
DaanVanVugt
left a comment
DaanVanVugt
left a comment
There was a problem hiding this comment.
very nice, this will be useful
olivhoenen
requested changes
Feb 6, 2025
Collaborator
olivhoenen
left a comment
olivhoenen
left a comment
There was a problem hiding this comment.
Thanks @maarten-ic , both the lazy loading and conversion (test on _tor-->_phi) are working like a charm!
Could you maybe mention these briefly in the example for netcdf in the doc?
prasad-sawantdesai
requested changes
Feb 6, 2025
imas/test/test_nc_validation.py
Outdated
| # This one is valid: | ||
| NC2IDS(memfile, factory.core_profiles()).run() | ||
| ids = factory.core_profiles() | ||
| NC2IDS(memfile, ids, ids.metadata, None).run() |
Collaborator
There was a problem hiding this comment.
Does the run method need a Boolean (lazy) parameter?
Collaborator
Author
There was a problem hiding this comment.
Good point, fixed that now. Also created #18, could you have a look at that?
…thon into feature/lazy-load-from-netcdf
Collaborator
Author
Good suggestion! I've added a table with supported (and unsupported) features with links to the sections with further details. Please check if this works for you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements the following improvements for the netCDF backend:
get(). This has the same limitations as the automatic conversion usingimas_core, as outlined in the documentation.N.B. automatic conversion during
put()is still not supported, since this is rarely needed and easily worked around.IDSPrimitive.value.setterlogic when loading data from a netCDF file (the same optimization was already in place for reading from animas_corebackend).