Skip to content

Implement read --follow #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 21, 2022
Merged

Implement read --follow #700

merged 7 commits into from
Oct 21, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Oct 20, 2022 •
edited
Loading

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request cloud-common Applies to every cloud vendor ui/ux User interface/experience leo standalone CLI binary labels Oct 20, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Oct 20, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 15:48 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 15:49 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 16:02 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review October 20, 2022 17:15
@0x2b3bfa0 0x2b3bfa0 requested a review from a team October 20, 2022 17:16
dacbd
dacbd approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and works just fine. Can certainly have a follow-up that is "streaming" logs.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 22:03 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic October 20, 2022 22:03 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic October 20, 2022 22:03 Abandoned
@0x2b3bfa0 0x2b3bfa0 requested a deployment to automatic October 20, 2022 22:03 Abandoned
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 20, 2022 22:03 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 03:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 03:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 03:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 03:06 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 05:25 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Oct 21, 2022
Open
5 tasks
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd October 21, 2022 05:29
tasdomas
tasdomas approved these changes Oct 21, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 09:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 09:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 09:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 09:26 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to automatic October 21, 2022 09:26 Inactive
@dacbd dacbd temporarily deployed to automatic October 21, 2022 19:16 Inactive
@dacbd dacbd temporarily deployed to automatic October 21, 2022 19:16 Inactive
@dacbd dacbd temporarily deployed to automatic October 21, 2022 19:16 Inactive
@dacbd dacbd temporarily deployed to automatic October 21, 2022 19:16 Inactive
@dacbd dacbd temporarily deployed to automatic October 21, 2022 19:16 Inactive
@dacbd dacbd enabled auto-merge (squash) October 21, 2022 19:16
@dacbd dacbd merged commit d53e68f into master Oct 21, 2022
@dacbd dacbd deleted the follow branch October 21, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@tasdomas tasdomas tasdomas approved these changes

@dacbd dacbd dacbd approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
cloud-common Applies to every cloud vendor enhancement New feature or request leo standalone CLI binary ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x2b3bfa0 @tasdomas @dacbd