Skip to content

Fix multiple resources logs #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix multiple resources logs #445

merged 2 commits into from
Mar 14, 2022

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega requested a review from casperdcl March 14, 2022 17:55
0x2b3bfa0
0x2b3bfa0 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me; let's wait for @casperdcl's take on prose. 📖

casperdcl
casperdcl approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well it's a fairly accurate error message so "my take on prose" is probably not needed.

Python is so much more legible... d = data.get('d', {})['ResourceData'] will auto-raise as useful a KeyError if needed.

@casperdcl casperdcl merged commit 96b20b5 into master Mar 14, 2022
@casperdcl casperdcl deleted the fix/logs-multiple-resources branch March 14, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

+1 more reviewer

@casperdcl casperdcl casperdcl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@DavidGOrtega DavidGOrtega

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task Logs are failing for multiple resources
3 participants
@DavidGOrtega @casperdcl @0x2b3bfa0