debug options for validation

[dacbd]

I added a simple sanity log to assist with any future debugging or inspection in GitHub action logs.

I believe that most users especially when constructing their initial tooling aren't pinning the version of CML to install.
My reasoning for this addition comes from the recent release of CML 0.7.0 -> 0.7.1, there was a discussion on discord about an error the was patched, I encountered a nearly identical error and wanted to be certain what the latest version was...

example output:

[dacbd]

Looks like versions of CML do not support --version I will amend the PR to support this condition.

[DavidGOrtega]

Looks like versions of CML do not support --version I will amend the PR to support this condition.

Thats strange. Which version of CML does not support --version?

[dacbd]

@DavidGOrtega it had failed on 0.3.0

@0x2b3bfa0 good catch.

[dacbd]

example error result:

[dacbd]

Makes good sense to me, Is this the preferred course? @casperdcl

…

On Thu, Oct 7, 2021, 09:25 Casper da Costa-Luis ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/utils.js <#51 (comment)>: > @@ -21,7 +21,10 @@ const setupCml = async opts => { if (sudo) { try { sudoPath = await exec('which sudo'); - } catch (err) {} + } catch (err) { + console.log('Failed find the sudo binary.', err); + process.exit(1); if we changed https://github.com/iterative/setup-cml/blob/a7b00a80a68861804bbdd73396f56b81d5ce999f/action.yml#L11 to default: false & bumped the action version number, then it would be fine to fail upon sudo not found. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIN7M67F6W74NRFDJ3JZALUFXCYNANCNFSM5ERX4R2Q> .

[dacbd]

@0x2b3bfa0 what do you think with these updates?

[dacbd]

Example usage:

[DavidGOrtega]

@dacbd sorry for the super late reply, are you happy with it?
There is a test failing

[dacbd]

@DavidGOrtega no worries, my fork has been sufficient for my own use/debugging. I have looked at the error in the checks and I'm not sure what's causing it?

I'm fine with closing this and maintaining my own setup action to help with my testing, but if you feel it would be useful for others at all I would like to see it merged.

[DavidGOrtega]

I think is useful specially coming from you. What I do not get is why the original --version option did not work.

I have looked at the error in the checks and I'm not sure what's causing it?

Let me see 👀

[dacbd]

I think is useful specially coming from you.

❤️

What I do not get is why the original --version option did not work.

CML 0.3.0 did not have a --version it was added later

I have looked at the error in the checks and I'm not sure what's causing it?

Let me see 👀

Thanks, my inner voice has written it off as a weird GitHub cross-account ref thing.

I did mess around with the action a bit (made a main branch) on mine but it has been long enough ago I don't remember what I was trying to do? 🤣 So these links might not be helpful, but it does spam my email every day... https://github.com/dacbd/setup-cml/actions

v1...dacbd:main#diff-55f05888fd854d9962bdd4d8ccf23a07b610990f58174397b2586b58f8937428

[casperdcl]

need to resolve conflicts @dacbd :)

[dacbd]

I think we can close and revisit later, nice to have but not required.