Skip to content

Conversation

vadimeisenbergibm
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 31, 2018
@vadimeisenbergibm vadimeisenbergibm changed the title added TCP and MONGO to the list of protocols supported by Egress Rules add TCP and MONGO to the list of protocols supported by Egress Rules Jan 31, 2018
Copy link
Contributor

@ZackButcher ZackButcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pilot respects the new list of protocols already, right?

@vadimeisenbergibm
Copy link
Contributor Author

@ZackButcher yes, already starting from 0.3.0.

Pilot respects the new list of protocols already, right?

@vadimeisenbergibm vadimeisenbergibm merged commit 0318d4c into istio:master Jan 31, 2018
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
* Created the ConfigManager interface

* Added ConfigManagerImpl

* Removed ConfigManager interface and rename the ConfigManagerImp to ConfigManager.

* Applied code reviews

* Created the service_management_fetch library

* Removed unimplemented method definition

* Moved ServiceManagement related code to the library

* Created ServiceManagementFetch class

* Removed unnecessary headers inclusion, fixed typo, used std::move

* Used lvalue reference for std::move

* Removed const definition

* Renamed variables and method names

* Removed console debugging codes

* Made service config fetch in parallel. Changed constructor of ConfigsFetchInfo

* Changed the callback prototype in test cases

* Moved config_id and percentage variables to lambda capture

* Added missing proto files
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
Automatic merge from submit-queue.

[DO NOT MERGE] Auto PR to update dependencies of mixerclient

This PR will be merged automatically once checks are successful.
```release-note
none
```
nacx pushed a commit to nacx/api that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants