Skip to content

Clean up and add example for C.32 - raw pointers #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 13, 2022
Merged

Clean up and add example for C.32 - raw pointers #1909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1ebedb8
Update CppCoreGuidelines.md
bgloyer May 4, 2022
decef18
Update CppCoreGuidelines.md
bgloyer May 4, 2022
05100a9
Update isocpp.dic
bgloyer May 4, 2022
3c79265
Merge branch 'isocpp:master' into C_32
bgloyer Jun 6, 2022
445945f
use snake casing
bgloyer Jun 6, 2022
e0aec51
sake case naming
bgloyer Jun 6, 2022
c88082e
Merge pull request #2 from bgloyer/C_32_snake
bgloyer Jun 6, 2022
9acf9ac
C 32 comments (#3)
bgloyer Jun 16, 2022
60c6eb7
Merge pull request #8 from bgloyer/C_32
bgloyer Jul 9, 2022
93f9778
Merge pull request #10 from bgloyer/master_c32_merge
bgloyer Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions CppCoreGuidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4993,12 +4993,19 @@ There is a lot of code that is non-specific about ownership.

##### Example

???
class legacy_class
{
foo* m_owning;
bar* m_observer;
}

The only way to determine ownership may be to dig through the code to look for
allocations. If a pointer or reference is owning, document it as owning.

##### Note

If the `T*` or `T&` is owning, mark it `owning`. If the `T*` is not owning, consider marking it `ptr`.
This will aid documentation and analysis.
Ownership should be clear in new code (and refactored legacy code) according to [R.20](#Rr-owner) for owned
pointers and [R.3](#Rr-ptr) for non-owned pointers. References should never own [R.4](#Rr-ref).

##### Enforcement

Expand Down
3 changes: 3 additions & 0 deletions scripts/hunspell/isocpp.dic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ Lakos
Lakos96
Lavavej
LCSD05
legacy_class
lifecycle
*life-time
linearization
Expand All @@ -301,6 +302,8 @@ lvalues
m1
m2
m3
m_owning;
m_observer;
macros2
malloc
mallocfree
Expand Down