Skip to content

Load boundaries only once #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Load boundaries only once #421

wants to merge 2 commits into from

Conversation

aaron-kaplan
Copy link
Collaborator

On a slow connection, complex admin boundary layers take a long time to load. This doesn't fix that, but it reduces the impact by loading them only once, on initial page load, rather reloading them than every time any of the controls change.

@aaron-kaplan aaron-kaplan requested a review from remicousin May 9, 2024 16:04
@aaron-kaplan
Copy link
Collaborator Author

Oops, forgot to add a reviewer when I sent this last week.

@remicousin
Copy link
Contributor

where is this branched from? there is no config-dev-sample.yaml in this branch. Is that on purpose? Do you want to rebase on master first?

@aaron-kaplan
Copy link
Collaborator Author

Rebased.

Copy link
Contributor

@remicousin remicousin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and behaves on 2 Senegal Maprooms. I thought I had problems in the past trying to have ids like tile_layer, defined in a CallBack and updated in another. But maybe that depends on subtle set up. And that was a while ago so I probably did it wrong, or was trying something else...

@aaron-kaplan
Copy link
Collaborator Author

You're right, there's supposed to be a callback validation step that checks that the declared inputs and outputs of all the callbacks exist in the layout. That check can be suppressed, but as far as I can see we haven't suppressed it. So I don't know why this works. Will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants