Refresh the uses of memref.assume_alignment in lit tests. #20925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few tests are updated to use the result of `memref.assume_alignment` because they care about the ops. Many `memref.assume_alignment` ops are removed from many lit tests because they do not need them. They don't use them at their pass scope. There are two tests not changed becaue of recent regression. I'l revisit it if I come back to the issue. For now, leave them as what they are: - SPIRV/test/tile_and_promote_cooperative_matrix.mlir - SPIRV/test/tile_and_vectorize_to_cooperative_ops.mlir Signed-off-by: hanhanW <[email protected]>
benvanik
approved these changes
May 29, 2025
Signed-off-by: hanhanW <[email protected]>
hanhanW
requested review from
antiagainst,
MaheshRavishankar,
kuhar,
qedawkins,
Groverkss and
pashu123
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few tests are updated to use the result of
memref.assume_alignmentbecause they care about the ops.Many
memref.assume_alignmentops are removed from many lit tests because they do not need them. They don't use them at their pass scope.There are two tests not changed because of recent regression. I'll revisit it if I come back to the issue. For now, leave them as what they are:
This is a follow-up to cbb7536