Skip to content

Refactor - napi wrappers #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Apr 14, 2024
Merged

Refactor - napi wrappers #107

merged 29 commits into from
Apr 14, 2024

Conversation

b-ma
Copy link
Collaborator

@b-ma b-ma commented Apr 12, 2024 •
edited
Loading

Built on top of #95

Quite a huge refactoring/cleaning

Fix #84

b-ma added 26 commits April 9, 2024 19:43
@b-ma
refactor: generalize AudioNode macros
0f7e6ab
@b-ma
refactor: audio node constructors
29a1898
@b-ma
refactor: clean AudioScheduledSourceNode interface
dd71871
@b-ma
refactor: js audio nodes getter / setters
7b2e1ad
@b-ma
refactor: getters and setters on rust side
026bc88
@b-ma
refactor: clean audio nodes methods
e3bf7e6
@b-ma
fix: handle sinkId check in AudioContext ctor
1c9e3c5
@b-ma
fix: throw error instead of rejecting promise in contructor
4d55103
@b-ma
refactor: clean AudioNode generation 2nd pass
5d6a58b
@b-ma
fix: expose Float64Array and Uint8Array to wpt
cea924d
@b-ma
refactor: do not generate AudioScheduledSourceNode
6608973
@b-ma
refactor JS audio param + remove factory methods from Rust
869af69
@b-ma
clippy
3bd7467
@b-ma
refactor: napi AudioParam implemented as class
8d819d4
@b-ma
refactor: clean exports and symbols
fac5b2d
@b-ma
fix: enforce private constructor + fix async methods on audio context
0166077
@b-ma
refactor: AudioBuffer options
eacdb98
@b-ma
fix: protect BaseAudioContext constructor
99e5d4c
@b-ma
refactor: OfflineAudioContext constructor
7ff3b6b
@b-ma
refactor: simplify argument handling
fa7d3da
@b-ma
cleaning
4d23356
@b-ma
fix: review AudioContext constructor
a1cb86a
@b-ma
refactor: remove isPlainObject helper
a940226
@b-ma
feat: share BaseAudioContext interface through macros + remove genera…
865c218 
…tor for audio contexts
@b-ma
refactor: remove audio_param.rs from generators, not required anymore
8afedea
@b-ma
refactor: clean generator script
d54636f
@b-ma b-ma mentioned this pull request Apr 13, 2024
Merged
@b-ma
Copy link
Collaborator Author

b-ma commented Apr 13, 2024

Ready to merge once upstream is published

Some wpt improvements too:

  RESULTS:
  - # pass: 6897
  - # fail: 692
  - # type error issues: 5

@b-ma b-ma marked this pull request as ready for review April 14, 2024 06:57
@b-ma b-ma merged commit 2068aa8 into main Apr 14, 2024
@b-ma b-ma deleted the refactor/napi-wrappers branch April 14, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving argument type check to JS side
1 participant
@b-ma