Skip to content

Various enhancements #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2018
Merged

Various enhancements #187

merged 3 commits into from
Jan 27, 2018

Conversation

richardschneider
Copy link
Contributor

@ghost ghost added the status/in-progress In progress label Jan 27, 2018
@codecov
Copy link

codecov bot commented Jan 27, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5bdbb67). Click here to learn what that means.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #187   +/-   ##
=========================================
  Coverage          ?   88.41%           
=========================================
  Files             ?       11           
  Lines             ?      561           
  Branches          ?        0           
=========================================
  Hits              ?      496           
  Misses            ?       65           
  Partials          ?        0
Impacted Files Coverage Δ
src/utils/index.js 91.37% <100%> (ø)
src/in-proc-node.js 76.19% <37.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bdbb67...d104aa8. Read the comment docs.

@richardschneider
Copy link
Contributor Author

As usual passes on Circle CI and fails on all others.

@victorbjelkholm The Jenkins linux tests are failing because of port issues. Could you take a look.

dryajov
dryajov approved these changes Jan 27, 2018
View reviewed changes
Copy link
Member

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @richardschneider

daviddias
daviddias requested changes Jan 27, 2018
View reviewed changes
src/in-proc-node.js Outdated
} else if (arg.startsWith('--pass')) {
this.opts.pass = arg.split(' ').slice(1).join(' ')
} else {
// TODO: maybe throw!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardschneider What's the real TODO here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diasdavid good catch. I removed the comment.

@daviddias daviddias merged commit 3bc94c1 into master Jan 27, 2018
@ghost ghost removed the status/in-progress In progress label Jan 27, 2018
@daviddias daviddias deleted the some-fixes branch January 27, 2018 21:09
@daviddias daviddias mentioned this pull request Jan 27, 2018
Closed
This was referenced Jan 27, 2018
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

+1 more reviewer

@dryajov dryajov dryajov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardschneider @dryajov @daviddias