-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is all red :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor
4c5b0f5
to
9424720
Compare
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
These need to be unskipped when #856 gets merged. This frees us to merge other changes while we're waiting for fixes to happen there. License: MIT Signed-off-by: Alan Shaw <[email protected]>
da9a90c
to
100bf90
Compare
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
@vasco-santos I've added temporary skips for the DHT tests that went into This will allow us to push forward and merge the remaining PRs for 0.34 and wait for the DHT branch to be ready. Can you please ensure that they get re-enabled in the DHT branch before they are merged into master? |
@vasco-santos @daviddias CI is 🍀 - ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it! I will rebase the DHT PR afterwards and re-enable them
No description provided.