Does not work with UglifyJS version 2

[lightninglu10]

• Version: 0.25.0
• Platform: JS
• Subsystem:

Type: Bug

Severity: Critical

Description:

Trying to build IPFS node in the browser, uglifyJS through webpack won't build the app.

static/js/main.725ac8bb.js from UglifyJs
Unexpected token: name (CID) [./~/cids/src/index.js:23,0][static/js/main.725ac8bb.js:8442,6]

Hey guys, I'm trying to build an IPFS node in my browser. Building the app with yarn run build using create-react-app gives the error above. It looks like it doesn't like the type CID. I've installed CID as well, but no go. Anyone know what's going on here?

[daviddias]

Thanks for reporting this, @lightninglu10 🌟

I believe this issue is related to libp2p/js-libp2p#65. tl;dr; We use the constructor name for the type checks and since Uglify changes it per module, a lack of treeshaking makes it create different names for the same module.

Weird to me that we actually do not use the constructor name anywhere in CID, I wonder if you are using the latest version of all the modules. @lightninglu10 mind trying using js-ipfs by installing it from the repo with npm install ipfs/js-ipfs? Let me know the result.

[lightninglu10]

@diasdavid Installed via yarn add ipfs/js-ipfs and it still gives me the error. I setup a bare bones repo with IPFS so you can try it here. In the root just run yarn run build and you'll get the webpack error.

https://github.com/lightninglu10/ipfs-test

[daviddias]

@lightninglu10 yeah, the issue comes from uglify or what uglify tries to do. We have to change the way we do some of the duck typing.

[cristiano-belloni]

Could it be that you're not transpiling ES6? create-react-app notoriously won't compile ES6 unless you eject (which removes all the advantages of using create-react-app)

[daviddias]

Same issue as ipfs-inactive/js-ipfs-http-client#611 (comment)

[cristiano-belloni]

@diasdavid Unfortunately, you're essentially saying that create-react-app users won't be able to use js-ipfs. And create-react-app, on its end, won't support es6 uglifying. It's sad.