http-client dag.put failed with invalid byte

[jtsmedley]

• Version: ipfs-http-client 53.0.1, go-ipfs v0.10.0

• Platform: Windows

• Subsystem:

Severity: Medium

Description: Running await ipfsClient.dag.put({"hello": "world") fails with an error of [Uncaught HTTPError: Invalid byte while expecting start of value: 0x5a]. Issue was not present before IPFS Desktop updated to 0.10.0

Steps to reproduce the error: Connect to local ipfs-go instance and attempt to put a DAG of {"hello": "world"}.

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[rvagg]

@achingbrain the DAG API is now out of sync between go-ipfs and js-ipfs-http-client and errors like this are going to start popping up. This particular error is going to be about the codec defaults, and what's more, the arguments have changed. format and input-enc are now replaced with store-codec and input-codec and both the defaults and behaviour are different, in subtle (but arguably much more clear, now) ways.

The default input-enc here is raw and format is dag-cbor and there's pre-processing done here before it's sent off to the server. So I think what's happening for this error is the JS object {hello: "world"} is encoded with dag-cbor and sent as bytes to the server. But the default input-codec is dag-json on the server and its receiving cbor bytes, so it's getting 0x5a when it really wants a valid JSON value character.

Defaults and options need to be updated here to match 0.10. I just don't know how you deal with the version mismatch if someone's using 0.9, but maybe you just don't?

https://github.com/ipfs/go-ipfs/blob/master/CHANGELOG.md#v0100-2021-09-30

[achingbrain]

Defaults and options need to be updated here to match 0.10. I just don't know how you deal with the version mismatch if someone's using 0.9, but maybe you just don't?

We've not addressed this before - if people are using the older version of go-ipfs they should use the older version of ipfs-http-client.

It could probably use a table in the README saying which versions of the client are compatible with which versions of go-ipfs and js-ipfs.

[jtsmedley]

This is the latest version of js-ipfs and go-ipfs. A chart would be great. Everything works fine before 0.10.

Thanks for checking into this!