-
Notifications
You must be signed in to change notification settings - Fork 525
Description
Updated 21 September to consolidate notes below and OOB discussion.
The need
At present, UI upload drawer doesn't provide progressive feedback on file import until it gives notice at end whether import was successful or failed. This is particularly problematic for large files.
Solution
Let's mitigate this in two ways:
2. Import progress in drawer as originally proposed in #1495
Original plan in #1495 was to include a functional progress bar in the import drawer, as sketched out in Figma mockups here. When that wasn't technically possible at the time, we switched to an indefinite indicator. If we can now implement as originally planned, let's do so.
2. Inline, inactive display of in-progress imports in Files screen
Let's also implement (as a separate issue/PR if need be) the mitigation originally planned in this issue for giving inline feedback that a file is being imported as a grayed-out row in the Files screen. Mockup below.
Original issue notes
At the moment UI provides no visual feedback on file(s) import, until the very end when it succeeds or fails. Which is not a big deal for small files where it's spontaneous, but no feedback on large files leaves an impression of nothing happening. As per measurements in #1534 importing 2gig size file takes somewhere between 10 to 12 seconds.
Plan was to introduce a progress animation once ipfs/js-ipfs-utils#52 would be shipped, but it introduced regression and attempt to address it ipfs/js-ipfs-utils#60 was rejected due to increased complexity.
Lets consider / discuss all the available options to address lack of visual feedback on file imports given existing constraints to figure out path forward.