-
Notifications
You must be signed in to change notification settings - Fork 42
adds authenticated transport and non-standard api path connections #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor nits, looks good in general, Thanks!
Not quite sure why this error is happening however I've traced the line of code causing it to go-ipfs-http-client/response.go Line 113 in 2b48dd3
update: Actually I was being a bit dump, the reason why its happening with this test, is because the test server isn't setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll let @Stebalien have one last look
I believe I forgot to commit removal of the file edit: I have pushed a commit to remove the |
@Stebalien lgtm-ed on IRC |
…auth adds authenticated transport and non-standard api path connections This commit was moved from ipfs/go-ipfs-http-client@b9c8a2f
This PR adds the ability to use
go-ipfs-http-client
with an endpoint expecting authorization, ie via JWT's. Additionally, it allows connectiongo-ipfs-http-client
to an endpoint that may not be using a standard path, ie/foo/bar/api/v0
as opposed to/api/v0
.Currently multiaddr doesn't support parsing of http paths, which is what
NewDirectAPIClient
works around. Initially I thoughtNewApiWithClient
might be usable instead, however since it expects a multiaddr and the multiaddr spec doesn't currently support parsing of http paths, this is needed.edit: Not quite sure why the travis build is failing, but it seems to be some kind of go version check when this part of the build runs
(cd $GOPATH/src/github.com/ipfs/go-ipfs; make install)